-
Notifications
You must be signed in to change notification settings - Fork 1.8k
bugfix: add "to yml" command #15254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: add "to yml" command #15254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I was thinking if we could get by with a .nu
version of this as part of the std
prelude. But supporting all the flags and documentation like this may still be kind of messy. So I am fine with the Rust-duplication alias.
Co-authored-by: Stefan Holderbach <[email protected]>
I thought the duplication was okay because that's already the case for |
Also what's your take on this? |
Yeah fine based on precedent as well. Let's go with this approach for now
I think it suffices that the command will appear in the autogenerated command help. |
Sure! How does it work, do I just push a new commit on the |
If you edit it in the web interface it will probably ask you to open a PR. If you start your changes locally, you will have to set the target branch of the PR to |
Hi @sholderbach I did that PR for the release note but I think nobody saw it |
Thanks! Sorry that I didn't get around to it. Nice user-friendly writeup! |
Description
This fixes #15240, which can be closed after merge.
User-Facing Changes
to yml
-> exactly the same asto yaml
Tests + Formatting
Cargo fmt and clippy 🆗
I added a test in the only place I could find where
to yaml
was already tested.I didn't see the
save.rs::convert_to_extension
function tested anywhere, but maybe I missed it.After Submitting
Not sure this needs an update on the documentation ❓ What do you suggest?