-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixup and improve book using_modules.md #1608
base: main
Are you sure you want to change the base?
Commits on Nov 1, 2024
-
Fix absolute path example item text
The relative example follows afterwards. This block only contains docs on absolute paths.
Configuration menu - View commit details
-
Copy full SHA for bf790aa - Browse repository at this point
Copy the full SHA bf790aaView commit details -
Fix NU_LIB_PATH -> NU_LIB_DIRS
`$env.NU_LIB_PATH` does not exist In the block that follows the correct name is being used.
Configuration menu - View commit details
-
Copy full SHA for 9eea190 - Browse repository at this point
Copy the full SHA 9eea190View commit details -
Remain consistent across code examples
The blocks demonstrate different things, but it's confusing to have different code - mixing both behavior changes through context and unnecessary code changes.
Configuration menu - View commit details
-
Copy full SHA for eec9199 - Browse repository at this point
Copy the full SHA eec9199View commit details -
Configuration menu - View commit details
-
Copy full SHA for f790b3f - Browse repository at this point
Copy the full SHA f790b3fView commit details -
Simplify sentences by dropping 'simply'
Increases readability and clarity. Using 'simply' can indicate that actions are simple. But adding it without a need for differentiation or qualification, they increase sentence complexity, making it harder to read and parse. The statements remain just as valid without them.
Configuration menu - View commit details
-
Copy full SHA for 41f99b4 - Browse repository at this point
Copy the full SHA 41f99b4View commit details -
Split absolute and relative path examples
The concern before this one already has split sections. Rather than a block with two mixed concerns, and a need for "or" text in a mixed-concern example attempting to demonstrate two things at once, having two blocks makes it much more obvious, distinct, and reference-able (when the reader is only interested in one aspect). It also simplifies the NU_LIB_DIRS concern a lot. Instead of a long block headline with a lot of mixed information, we do the same as the other concern earlier in the document: note the information in an important note block.
Configuration menu - View commit details
-
Copy full SHA for 1abe662 - Browse repository at this point
Copy the full SHA 1abe662View commit details
Commits on Nov 18, 2024
-
Revert "Remain consistent across code examples"
This reverts commit eec9199.
Configuration menu - View commit details
-
Copy full SHA for e5de007 - Browse repository at this point
Copy the full SHA e5de007View commit details -
Partially revert "Simplify sentences by dropping 'simply'"
This partially reverts commit 41f99b4.
Configuration menu - View commit details
-
Copy full SHA for 9068c24 - Browse repository at this point
Copy the full SHA 9068c24View commit details