-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ add a Contributing guide to parser and editor tools related stuff #1311
base: main
Are you sure you want to change the base?
Changes from 4 commits
ddfb23b
2e78699
bc66a93
535f9cc
8f8ad98
12f1c21
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,82 @@ | ||
--- | ||
title: Parser and other editor tools | ||
--- | ||
|
||
# Parser and other editor tools | ||
|
||
Hi! There is a lot of space to grow in this area, and the development is | ||
somewhat spaced in time, so I (@AucaCoyan) decided to make a document explaning | ||
the framework, conventions and other required knowledge to help others and | ||
myself with this section. | ||
|
||
## Parser | ||
|
||
The most important piece of this chapter is the parser. The parser is the bridge | ||
between the `*.nu` text files and the internal representation of object in | ||
nushell. Almost everything in this chapter interacts or is affected by the | ||
parser. | ||
|
||
### Current status | ||
|
||
The current production parser is not bad at all, but it has certain areas that | ||
some improvement that could be greately appreciated. Sophia [started a new parser](https://github.com/sophiajt/new-nu-parser/) | ||
and it's still on the works. The central idea of this new parser is that it | ||
will have multiple passes over the text, improving the typing structures by | ||
a lot. | ||
|
||
## Formatter | ||
|
||
We have [`nufmt`](https://github.com/nushell/nufmt), but is a little stagnated | ||
because it will probably need some rework after the new parser is landed. The | ||
current issue is a bug reading stdin from the cmdline. Ask @AucaCoyan anything! | ||
|
||
## LSPs | ||
|
||
LSP stands for Language Server Protocol, a [Microsoft document](https://microsoft.github.io/language-server-protocol/) | ||
to establish communication between text editors and parsers and other tools. | ||
|
||
We currently have 2 of them, one for VS Code and one for other terminal editors | ||
|
||
### VSCode | ||
|
||
This has [it's own extension](https://github.com/nushell/vscode-nushell-lang/) | ||
and it's the most advanced LSP. It was the first to appear it is bootstraped | ||
from a prototype of Microsoft. It's written in Typescript and interacts with | ||
`nu` in the command line to have: | ||
|
||
- hover | ||
- go to definition | ||
- auto-completions | ||
|
||
### nu-lsp | ||
|
||
This is a newer LSP that we would like to have as the long term for every editor | ||
. It's written in rust and it's on the `nushell/nushell` repo, in the | ||
[`crates/nu-lsp`](https://github.com/nushell/nushell/tree/main/crates/nu-lsp) | ||
folder. Interacts via stdin and stdout and it is useful for vim, | ||
neovim, helix and other text editors. Sadly, it doesn't have the same level of | ||
features of VSCode-nushell-lang, that's why we still can't replace it. | ||
|
||
## Tree-sitter | ||
|
||
We have another grammar: [tree-sitter nushell](https://github.com/nushell/tree-sitter-nu) this is useful for terminal text editors (nvim, helix, etc). VS Code doesn't have support for tree-sitter and its grammar [is written in tmLanguage](https://github.com/nushell/vscode-nushell-lang/blob/main/syntaxes/nushell.tmLanguage.json) | ||
It has the following goals: | ||
|
||
- Ability to serve as a parser for a repl | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would strike that line as this is probably misleading as it is not used in our repl. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it's from the tree-sitter-nu's readme. Would you recommend deleting line 65 in both cases? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hi! Did you have time to review this 😄 ? Thanks! |
||
- Ability to work in editors that support tree-sitter (hx, nvim, others) | ||
- Ability to work in rust | ||
- Fast | ||
- Ability to be utilized for syntax highlighting | ||
|
||
## I dont know a thing about all this, can you give me a hint on where to start? | ||
|
||
Sure! you can begin with these resources: | ||
|
||
- Adrian Hesketh gives an excellent talk about [how LSP works](https://youtu.be/EkK8Jxjj95s?si=KT3YdfV5LebbTzXp) | ||
- TeeJ explains [tree-sitter in a 15 min video](https://www.youtube.com/watch?v=09-9LltqWLY) | ||
- about the formatter: | ||
- Bob Nystrom worked with the dart formatter and [wrote a precious blog post](https://journal.stuffwithstuff.com/2015/09/08/the-hardest-program-ive-ever-written/) about his journey. The hackernews | ||
[post is also useful](https://news.ycombinator.com/item?id=22706242) for the | ||
comments! | ||
- and a [short overall view](https://blog.vjeux.com/2017/javascript/anatomy-of-a-javascript-pretty-printer.html) | ||
of how `prettier` works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few things missing from this list.
It also helps locate nu and if it finds it allow nu to be used as a terminal shell.
It displays Inlays
It allows you to have separate IncludeDirs
It has diagnostics to show errors
Most of this is laid out in the extension readme