Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move toolkit environment setting to a command #67

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Move toolkit environment setting to a command #67

merged 2 commits into from
Jan 30, 2024

Conversation

kubouch
Copy link
Contributor

@kubouch kubouch commented Jan 28, 2024 •
edited
Loading

Description

Instead of setting the environment on module import, it is now done in a command that needs to be called manually.

@kubouch kubouch requested a review from amtoine January 28, 2024 16:56
amtoine
amtoine reviewed Jan 29, 2024
View reviewed changes
toolkit.nu Show resolved Hide resolved
amtoine
amtoine approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@amtoine amtoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick update 🙏

let's land this 👍

@amtoine amtoine merged commit c54b077 into nushell:main Jan 30, 2024
3 checks passed
@kubouch kubouch deleted the toolkit-env-to-command branch January 30, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amtoine amtoine amtoine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kubouch @amtoine