Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the destination only if it exists #62

Merged
merged 2 commits into from
Jan 28, 2024
Merged

Conversation

amtoine
Copy link
Member

@amtoine amtoine commented Jan 28, 2024

Description

nupm install --force should not try to rm the content of $destination if it does not exist.
this PR adds a check for that and a test to the CI.

@amtoine amtoine requested a review from kubouch January 28, 2024 09:17
@kubouch kubouch merged commit 8fcec7a into nushell:main Jan 28, 2024
3 checks passed
@amtoine amtoine deleted the fix-61 branch January 28, 2024 10:36
amtoine added a commit to amtoine/nu-git-manager that referenced this pull request Jan 28, 2024
amtoine added a commit to amtoine/nushell-nupm that referenced this pull request Jan 28, 2024
amtoine added a commit that referenced this pull request Jan 28, 2024
related to
- #62
- nushell/nushell#11656

## Description
this commit reverts #62 because it
was just a bug introduced recently and now fixed in
nushell/nushell#11656.
amtoine added a commit to amtoine/nu-git-manager that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nupm install --force tries to remove non-existing destinations
2 participants