Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spread arguments to external commands #57

Merged

Conversation

amtoine
Copy link
Member

@amtoine amtoine commented Jan 11, 2024

related to

Description

this should fix the deprecation warning that we get these days

@amtoine
Copy link
Member Author

amtoine commented Jan 20, 2024

it's a pretty simple change, let's see how it goes.

@amtoine amtoine merged commit 66e2eaa into nushell:main Jan 20, 2024
3 checks passed
@amtoine amtoine deleted the fix-spreading-of-arguments-to-externals branch January 20, 2024 15:12
amtoine added a commit to amtoine/nu-git-manager that referenced this pull request Jan 20, 2024
amtoine added a commit to amtoine/nu-git-manager that referenced this pull request Jan 21, 2024
amtoine added a commit to amtoine/nu-git-manager that referenced this pull request Jan 21, 2024
amtoine added a commit to amtoine/nu-git-manager that referenced this pull request Jan 21, 2024
- rebase the changes from nightly
- bump
  - NGM to `0.5.0`
  - Nushell to `0.89.0`
  - Nupm to nushell/nupm#57

> **Note**
> ```nushell
> git diff nightly
> ```
> correctly gives
> ```diff
> diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
> index 9fc71c9..57437cb 100644
> --- a/.github/workflows/ci.yml
> +++ b/.github/workflows/ci.yml
> @@ -13,10 +13,10 @@ jobs:
>    tests:
>      uses: ./.github/workflows/nupm-tests.yml
>      with:
> -      nu_version: "0.88.1"
> -      nupm_revision: "6a9618fa21453bca4000ac33707b7aace0da35c7"
> +      nu_version: "0.89.0"
> +      nupm_revision: "66e2eaa848e3f72c1b4a841f26f4dc7efc4fedb9"
>  
>    documentation:
>      uses: ./.github/workflows/check-documentation.yml
>      with:
> -      nu_version: "0.88.1"
> +      nu_version: "0.89.0"
> diff --git a/pkgs/nu-git-manager-sugar/nupm.nuon
b/pkgs/nu-git-manager-sugar/nupm.nuon
> index 974b12f..bee1672 100644
> --- a/pkgs/nu-git-manager-sugar/nupm.nuon
> +++ b/pkgs/nu-git-manager-sugar/nupm.nuon
> @@ -1,6 +1,6 @@
>  {
>      name: "nu-git-manager-sugar"
> -    version: 0.4.0
> +    version: 0.5.0
> description: "A collection of extra Nushell tools to manage `git`
repositories."
> documentation:
"https://github.com/amtoine/nu-git-manager/blob/main/README.md"
>      maintainers: [
> @@ -9,7 +9,7 @@
>      ]
> license: "https://github.com/amtoine/nu-git-manager/blob/main/LICENSE"
>      dependencies: {
> -        nushell: 0.88.1
> +        nushell: 0.89.0
>          git: 2.40.1
>          optionals: {
>              "sugar gh": {
> diff --git a/pkgs/nu-git-manager/nupm.nuon
b/pkgs/nu-git-manager/nupm.nuon
> index e17af38..9fa9895 100644
> --- a/pkgs/nu-git-manager/nupm.nuon
> +++ b/pkgs/nu-git-manager/nupm.nuon
> @@ -1,6 +1,6 @@
>  {
>      name: "nu-git-manager"
> -    version: 0.4.0
> +    version: 0.5.0
> description: "A collection of Nushell tools to manage `git`
repositories."
> documentation:
"https://github.com/amtoine/nu-git-manager/blob/main/README.md"
>      maintainers: [
> @@ -9,7 +9,7 @@
>      ]
> license: "https://github.com/amtoine/nu-git-manager/blob/main/LICENSE"
>      dependencies: {
> -        nushell: 0.88.1
> +        nushell: 0.89.0
>          git: 2.40.1
>      }
>      type: "module"
> ```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant