Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 1 #74

Merged
merged 28 commits into from
Aug 11, 2017
Merged

Milestone 1 #74

merged 28 commits into from
Aug 11, 2017

Conversation

li-kai
Copy link
Member

@li-kai li-kai commented Aug 9, 2017

Fixes #67, #64, #63, #62

li-kai and others added 24 commits August 9, 2017 16:38
* Upgrade dependencies

* Update front page design

* Add minor styling improvements

* Enable http2 server push

* Minor ui improvements

* Add subtle animation for page transition
Introduce shortcode and new script

Add shortcode to legacy posts

Add friday hack footer

PR changes

Add requirements.txt
* Remove scaled images

* Move images to images folder

* Fix image path

* Remove duplicated sponsor footer

* Replace with image lintks

* Compress images

* Set max-size on sponsor logo
@li-kai li-kai added this to the 1.0 redesign + hugo + gh-pages milestone Aug 9, 2017
@li-kai
Copy link
Member Author

li-kai commented Aug 9, 2017

Deploy preview ready!

Built with commit 500cf20

https://deploy-preview-74--nushackers.netlify.com

@li-kai li-kai force-pushed the milestone-1 branch 2 times, most recently from ca663a7 to fd201b7 Compare August 9, 2017 09:08
@donjar
Copy link
Member

donjar commented Aug 10, 2017

Great job @li-kai!! 👏

Was wondering about the "Friday Hacks" section in the front page though. I find it a bit weird clicking "Show more" shows from 0 to 2. Maybe change it to "show" instead, and maybe add a link to show all the Friday Hacks?

Also, not sure how I feel about https://deploy-preview-74--nushackers.netlify.com/about/. Since the sidebar is at the left, I am not very sure, if I am a newcomer where should I read the page first?

@li-kai
Copy link
Member Author

li-kai commented Aug 10, 2017

@donjar It was on the left for the original, which I added before redesign. Switched to the other side.

Now the the list should show at least 2, and only a "show more" if there is more... The full list is at /fh/, but I don't see any point of the full list when we have no taxonomies yet. Milestone 2 I guess.

@li-kai li-kai merged commit 500cf20 into master Aug 11, 2017
@donjar donjar deleted the milestone-1 branch August 16, 2017 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants