forked from se-edu/duke
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branch level 9 find #327
Open
yuqiaoluolong
wants to merge
29
commits into
nus-cs2113-AY2021S1:master
Choose a base branch
from
yuqiaoluolong:branch-Level-9-Find
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Branch level 9 find #327
yuqiaoluolong
wants to merge
29
commits into
nus-cs2113-AY2021S1:master
from
yuqiaoluolong:branch-Level-9-Find
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
& a little bit customizes: 1. add online of " Here is yuqiaoluolong's Duke: " before each echo. 2. add a couple of "<" and ">" in the beginning and the end of the horizontalLine
&customizes: 1. add the second indentation 2. add a line between Duke's response and user's input command &optimizations: 1. delete unused import java.io.*;
…not have correct spacing It is messy if the naming and spacing does not follow some rules Let's *change String name Greet to greet *change String name Bye to bye *add a space between while and "(" *delete the redundant spacing before "case" in switch statement
original main classes: level-3 original Task classes: level-3 To achieve level-4, need to apply polymorphism Task classes: add a method toString() Todo classes: extends Task Deadline classes: extends Task add one more variable by (ddl time) Event classes: extends Task add one more variable at (happening time) main class: edit the format of output according to level-4 requirements and add a condition when user typed unexpected strings
Edit the file called input.txt and Expected.TXT to test There is still a problem of Troubleshooting and don't know how to use the dos2unix utility
Change the name of string respond to outputStatement Add one String variable wrongWarning to hold a long string Add two String variables description and date to hold the this.description and by or at date entered by user
correct some names of constants add some methods to make the code inside main class clearer
4 conditions of exceptions are added the empty todo command exception is caught the empty deadline command exception is caught the empty event command exception is caught the command out of the scope exception is caught
Duke.java is put into the package Duke.command Task.java, Todo.java, Deadline.java, and Event.java are put into the package Duke.task The exceptions caused by the command "done" and "done x" where x is out of the boundary of the task list.
use an ArrayList<Task> to store the tasks instead of Task[ ]
2nd version use an ArrayList<Task> to store the tasks
Added the support for deleting tasks from the list.
Add fileWriting method so that whenever the task list changes, the tasks would be saved in the hard disk automatically
# Conflicts: # src/main/java/Duke/command/Duke.java
extracted ui class extracted storage class extracted parser class extracted taskList class extracted command class extracted DukeException class
displayed the time of deadlines and events in a different way from the way user entered them.
added a function for users to search for tasks with certain key words.
Branch level 8 dates and times
…nch-Level-9-Find
Merge commit 'd805b90e6e0889c56d1513abd7326c8769719a85' into branch-Level-9-Find # Conflicts: # src/main/java/Duke/command/Command.java # src/main/java/Duke/storage/Storage.java # src/main/java/Duke/task/Deadline.java # src/main/java/Duke/task/Event.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.