-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wamps-jp] iP #761
Open
wamps-jp
wants to merge
40
commits into
nus-cs2103-AY2324S1:master
Choose a base branch
from
wamps-jp:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[wamps-jp] iP #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding guard clauses to methods with many conditionals allows the whole program to be more reader-friendly, as well as more efficient. Guard clauses were thus added to the case checking in Ui.java.
Add assertions
Branch A-CodeQuality was behind the changes made to the master branch. Merging branch master to branch-A-CodeQuality was therefore necessary. In addition, it added the assertions made in branch-A-Assertions. Keeping the code up to date is necessary.
Improve code quality
In addition to ToDo, Deadline, and Event, added FixedDurationTask Handles tasks that have a set duration but no schedule Increases overall functionality of the chatbot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remi
Remi the Reminder Bot keeps track of your tasks for you
What we've got on the list:
Note
Please check out the command list before starting out - it'll be pretty hard to operate without it!
Commands
to get started: