[W5][T12-3]Tan Kian Wei Jason #167
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flxffy
reviewed
Feb 13, 2019
melpulomas
reviewed
Feb 13, 2019
nhs-work
approved these changes
Feb 16, 2019
| @@ -72,6 +72,11 @@ Examples: | |||
| Shows a list of all persons, along with their non-private details, in the address book. + | |||
| Format: `list` | |||
|
|
|||
| == Listing all persons : `sort` | |||
|
|
|||
| Sorts the address book in alphabetical order. + | |||
There was a problem hiding this comment.
It is unclear which field of the address book is being sorted.
| @@ -73,33 +74,36 @@ public Command parseCommand(String userInput) { | |||
|
|
|||
| switch (commandWord) { | |||
|
|
|||
| case AddCommand.COMMAND_WORD: | |||
| return prepareAdd(arguments); | |||
| case AddCommand.COMMAND_WORD: | |||
There was a problem hiding this comment.
Note that there should not be indentation for case clauses.
| /** | ||
| * Asserts that the addressbook has been successfully sorted. | ||
| * | ||
| * The addressBook passed in will not be modified (no side effects). |
There was a problem hiding this comment.
Are you sure that sorting the address book does not result in a different ordering of the persons?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added sort command which sorts the addressbook in alphabetical order.
Also updated tests and user documentation to include sort command.