[W5.7][F10-2]Liu Xiaohang #446
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 13, 2018 13:47
wn
suggested changes
Sep 13, 2018
wn
suggested changes
Sep 13, 2018
wn
reviewed
Sep 13, 2018
| @@ -81,6 +81,17 @@ public UniquePersonList(UniquePersonList source) { | |||
| return Collections.unmodifiableList(internalList); | |||
| } | |||
|
|
|||
| /** | |||
| * Returns an unmodifiable java List view with elements cast as immutable {@link ReadOnlyPerson}s. | |||
wn
reviewed
Sep 13, 2018
| @@ -23,6 +23,7 @@ public CommandResult execute() { | |||
| + "\n" + ViewAllCommand.MESSAGE_USAGE | |||
| + "\n" + HelpCommand.MESSAGE_USAGE | |||
| + "\n" + ExitCommand.MESSAGE_USAGE | |||
| + "\n" + SortCommand.MESSAGE_USAGE | |||
wn
reviewed
Sep 13, 2018
| public static final String COMMAND_WORD = "sort"; | ||
|
|
||
| public static final String MESSAGE_USAGE = COMMAND_WORD + ": sort people in the address book.\n" | ||
| + "Example: " + COMMAND_WORD; |
wn
reviewed
Sep 13, 2018
| import seedu.addressbook.data.person.UniquePersonList; | ||
| import seedu.addressbook.data.tag.Tag; | ||
|
|
||
| public class SortCommand extends Command{ |
jlks96
approved these changes
Sep 13, 2018
| @@ -36,6 +36,16 @@ public static String getMessageForPersonListShownSummary(List<? extends ReadOnly | |||
| return String.format(Messages.MESSAGE_PERSONS_LISTED_OVERVIEW, personsDisplayed.size()); | |||
| } | |||
|
|
|||
| /** | |||
| * Constructs a feedback message to summarise an operation that displayed a list of sorted persons. | |||
There was a problem hiding this comment.
summarize (use American spelling), displays
| * @param personsDisplayed used to generate summary | ||
| * @return summary message for persons displayed | ||
| */ | ||
| public static String getMessageForPersonSortShownSummary(List<? extends ReadOnlyPerson> personsDisplayed) { |
There was a problem hiding this comment.
Hmm... method name is not that intuitive
| * Any changes to the internal list/elements are immediately visible in the returned list. | ||
| */ | ||
| public List<ReadOnlyPerson> sortedListView() { | ||
| //internalList.sort(); <--how to make this line work instead of using Collections.sort()? :( |
There was a problem hiding this comment.
https://docs.oracle.com/javase/8/docs/api/java/util/List.html
You have to pass in a comparator in this case. However, we usually just use Collections.sort/ Arrays.sort
| case HelpCommand.COMMAND_WORD: // Fallthrough | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sort command. Use the idea from the instructions on the CS2103/T website "Add a SortCommand class but make it simply a copy of the the existing ListCommand. Direct the sort command to the new SortCommand."