[W5.7][F11-4]Ng Yuan Yun Nigel #445
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Happytreat
reviewed
Sep 13, 2018
| @@ -72,7 +72,8 @@ public UniquePersonList getAllPersons() { | |||
| * Returns a new UniquePersonList of all persons in the address book at the time of the call sorted in alphabetical order. | |||
| */ | |||
| public UniquePersonList getSortedAllPersons() { | |||
| return new UniquePersonList(allPersons).sort(); | |||
| UniquePersonList toSort = new UniquePersonList(allPersons); | |||
| return toSort.sort(); | |||
There was a problem hiding this comment.
Doesn't update the main list of persons? Only sort the new list created (the copy of the main list)?
ZhiWei94
reviewed
Sep 13, 2018
| @@ -160,7 +165,7 @@ Format: `clear` | |||
|
|
|||
| Exits the program. + | |||
| Format: `exit` | |||
|
|
|||
| l | |||
There was a problem hiding this comment.
There is the extra "l" which may have affected the presentation, and GitHub's ability to session the paragraph properly
jelneo
approved these changes
Sep 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.