[W5.7][T16-4]Rezky Arizaputra #427
Conversation
|
Looks good. Just need to correct the wrong parts and update the IO tests (input.txt and expected.txt) |
| import org.junit.Before; | ||
| import org.junit.Test; | ||
| import seedu.addressbook.data.AddressBook; | ||
| import seedu.addressbook.data.person.*; |
There was a problem hiding this comment.
Avoid using * for imports. Because then the reader can explicitly see what was imported/used in this file. It is also better practice to import only things that you need instead of importing the entire library/module
|
|
||
| public static final String MESSAGE_SORTED = "Address book is sorted"; | ||
| @Override | ||
| public CommandResult execute() { |
There was a problem hiding this comment.
The indentation for this method is inconsistent with the lines before it. Java unlike languages like Ruby or Python compiles fine with inconsistent indentation. But it is still important to have consistent proper indentation to make it easy for the user to read and mke your code neat in general
| import java.util.Collections; | ||
| import java.util.List; | ||
|
|
||
| import static org.junit.Assert.*; |
There was a problem hiding this comment.
There is no space between this import line and the public class SortCommandTest { line but there is a line gap before this line. Just try to standardise line breaks :) Look at Addressbook-4 for inspiration.
| assertEquals(expectedMessage, result.feedbackToUser); | ||
| assertEquals(expectedAddressBook.getAllPersons(), actualAddressBook.getAllPersons()); | ||
| } | ||
|
|
There was a problem hiding this comment.
I think might be good to not have so many blank lines at the end of the class. Also, assertCommandBehaviour does not have a blank line before its closing brace while assertSortingSuccessful does.
| /** | ||
| * Sorts all people in the list. | ||
| */ | ||
| public void sort() {Collections.sort(internalList, new CompareName()); } |
There was a problem hiding this comment.
There is no space after { but space before }
No description provided.