-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[w5.7][T12-2] Li Xinze #423
base: master
Are you sure you want to change the base?
Conversation
Hi @lixinze777, your pull request title is invalid. For PR sent to satisfy a learning outcome, the PR name should be in the format of For team PR, the PR name should be in the format of Please follow the above format strictly and edit your title for reprocessing. Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at nus-se-pr-bot and add a link to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, however since you've made the modification to make the find command case insensitive, perhaps you should update the documentation and test cases to ensure its working properly as intended.
Good job on completing the activity.
Some comments added. Please close the PR after reading the comments.
import java.util.HashSet; | ||
import java.util.List; | ||
import java.util.Set; | ||
import java.util.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remember to disable intellij auto import wildcard
Why is wild card import bad?
* This is a case insensitive version of disjoint method | ||
* | ||
* @param coll1 | ||
* @param coll2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as mentioned during the lecture, such tags with no further explanation or variable name is self explanatory, can exclude them from the javadocs.
The find function is now case-insensitive