[W6.1f][F10-B2] Chen Huijia #873
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damithc
reviewed
Oct 14, 2017
| @@ -15,5 +15,6 @@ | |||
| public CommandResult execute() { | |||
| return new CommandResult(MESSAGE_EXIT_ACKNOWEDGEMENT); | |||
| } | |||
|
|
|||
| @Override | |||
| public boolean isMutating() { return false; } | |||
There was a problem hiding this comment.
Coding standard violation:exclamation: One or more of these problems noticed:
- extra/missing spaces
- brace style problem
- missing braces
- name doesn't follow naming convention
- line too long
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LO: Abstract
added abstract method isMutating to Commands (since execute is already abstract)