feat(systemd): use upstream unit definitions #187
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(that is, unit files provided by the packages in `systemd.packages`) by using NixOS's `utils.systemdUtils.lib.generateUnits` function. BREAKING CHANGE: unit collisions are now allowed, meaning that certain unit files will end up in `systemd/system/<some-unit>.d/overrides.conf` when `systemd/system/<some-unit>` already exists, whereas previously this conflict would trigger a fatal error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is, incorporate the unit files provided by the packages in
systemd.packages, accomplished by using NixOS'sutils.systemdUtils.lib.generateUnitsfunction.This PR is meant to be a sort of RFC. I've found this changeset to be useful when consuming NixOS modules in my system-manager configuration, as some of those modules leave important configurations up to the upstream unit definitions (e.g.
virtualisation.libvirtddoesn't define anExecStart, which instead comes from thelibvirtdpackage's includedlibvirtd.servicefile).