Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): relevant usage on CLI errors, remove app archive on deploy, app list use configured organization #62

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

jfeodor
Copy link
Contributor

@jfeodor jfeodor commented Dec 9, 2024

  • Show proper sub-commands usage text instead of the root usage when errors occur
  • deploy command, remove temporary app archive after uploading it, rather than waiting for the deployment to complete
  • app list command now uses the configured organization if none is specified with the --organization flag.
  • Store CLI arguments in objects, to avoid accidentally referring to them within the packages
  • Extract repeated code for app identifier arguments
  • Move logic for refreshing access tokens to the auth package
  • Move logic for validating app identifiers into the appident package
  • Move organization creation wizard logic into the cmd/organization/create package to simplify
  • Split several commands logic, so that cmd.go contains the actual command definition

* Show proper sub-commands usage text instead of the root usage when errors occur
* Store CLI arguments in objects, to avoid accidentally referring to them within the packages
* Extract repeated code for app identifier arguments
* Move logic for refreshing access tokens to the `auth` package
* Move logic for validating app identifiers into the `appident` package
* Move organization creation wizard logic into the `cmd/organization/create` package to simplify
* Split several commands logic, so that `cmd.go` contains the actual command definition
@jfeodor jfeodor changed the title fix(cli): show proper usage message on errors fix(cli): show proper usage message on errors, and some clean-up Dec 9, 2024
@jfeodor jfeodor changed the title fix(cli): show proper usage message on errors, and some clean-up fix(cli): show proper usage message on errors, and some refactoring Dec 9, 2024
@jfeodor jfeodor changed the title fix(cli): show proper usage message on errors, and some refactoring fix(cli): remove app archive faster on deploy, show proper usage message on errors, and some refactoring Dec 9, 2024
Copy link
Contributor

@moroderNumerous moroderNumerous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice refactoring and improvent of the help message 😄

cmd/app/list/cmd.go Outdated Show resolved Hide resolved
cmd/logs/cmd.go Show resolved Hide resolved
cmd/root.go Outdated Show resolved Hide resolved
@jfeodor jfeodor changed the title fix(cli): remove app archive faster on deploy, show proper usage message on errors, and some refactoring fix(cli): relevant usage on CLI errors, remove app archive on deploy, app list use configured organization Dec 10, 2024
@moroderNumerous moroderNumerous merged commit b6df1a0 into main Dec 10, 2024
14 checks passed
@jfeodor jfeodor deleted the fix_error_usage_and_some_refactoring branch December 10, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants