fix: upload app source buffer

numerous-com · Jun 10, 2024 · 8af23de · 8af23de
1 parent 05de2a4
commit 8af23de
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/cli/internal/app/upload_app_source.go b/cli/internal/app/upload_app_source.go
@@ -15,7 +15,7 @@ func (s *Service) UploadAppSource(uploadURL string, archive io.Reader) error {
 		return err
 	}
 
-	req, err := http.NewRequest(http.MethodPut, uploadURL, archive)
+	req, err := http.NewRequest(http.MethodPut, uploadURL, &buf)
 	if err != nil {
 		return err
 	}

diff --git a/cli/internal/app/upload_app_source_test.go b/cli/internal/app/upload_app_source_test.go
@@ -22,7 +22,7 @@ func TestUploadAppSource(t *testing.T) {
 		doer.On("Do", mock.Anything).Return(nilResp, testError)
 		s := Service{uploadDoer: &doer}
 
-		err := s.UploadAppSource("http://some-upload-url", nil)
+		err := s.UploadAppSource("http://some-upload-url", io.NopCloser(bytes.NewReader([]byte(""))))
 
 		assert.ErrorIs(t, err, testError)
 	})
@@ -33,15 +33,15 @@ func TestUploadAppSource(t *testing.T) {
 		doer.On("Do", mock.Anything).Return(&resp, nil)
 		s := Service{uploadDoer: &doer}
 
-		err := s.UploadAppSource("http://some-upload-url", nil)
+		err := s.UploadAppSource("http://some-upload-url", io.NopCloser(bytes.NewReader([]byte(""))))
 
 		assert.ErrorIs(t, err, ErrAppSourceUpload)
 	})
 
 	t.Run("given invalid upload URL then it returns error", func(t *testing.T) {
 		s := Service{uploadDoer: &test.MockDoer{}}
 
-		err := s.UploadAppSource("://invalid-url", nil)
+		err := s.UploadAppSource("://invalid-url", io.NopCloser(bytes.NewReader([]byte(""))))
 
 		assert.Error(t, err)
 	})