✅(backend) fix flaky tests #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems to have a race condition, sometimes the tmp file is not deleted before the test assertion. We let the test sleep for 0.5 second before the assertion.
AntoLC
added
bug
AntoLC
changed the title
AntoLC
force-pushed
the
fix/flaky-test
branch
from
9b1acd8
to
9bb3ef1
Compare
sampaccoud
approved these changes
Sep 23, 2024
.github/workflows/impress.yml
Outdated
| @@ -178,6 +178,9 @@ jobs: | |||
| -v /data/media:/data \ | |||
| minio/minio server --console-address :9001 /data | |||
|
|
|||
| - name: Add delay to wait for Minio to start correctly | |||
| run: sleep 5 | |||
There was a problem hiding this comment.
maybe use something like this to avoid wasting time?
https://github.com/openfun/joanie/blob/main/.circleci/config.yml#L227
AntoLC
force-pushed
the
fix/flaky-test
branch
from
ba3770d
to
5886c34
Compare
MinIO server need to be initialized before running the job to configure MinIO. We add a delay to wait for MinIO server to be ready.
AntoLC
force-pushed
the
fix/flaky-test
branch
from
5886c34
to
e5425a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
✅(backend) fix flaky test on tmp file:
It seems to have a race condition, sometimes the tmp file is not deleted before the test assertion. We let the test sleep for 0.5 second before the assertion.
✅(CI) fix flaky test on Minio initialized:
Minio server need to be initialized before running the job to configure Minio.
We add a delay to wait for Minio server to be ready.