✨(frontend) one-click document creation #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
4 tasks
arnaud-robin
force-pushed
the
feature/editable-title
branch
from
958de0b
to
e892d41
Compare
the sticky panel editor is not working properly, the panel editor should be sticky until the bottom when the user scrolls the page.
AntoLC
force-pushed
the
feature/editable-title
branch
2 times, most recently
from
95a81f2
to
a894269
Compare
We now redirect to the OIDC when a user is on a private doc and get a 401 error.
In order to stay DRY, we moved the function to know if a user is from a firefox browser from useSaveDoc to utils userAgent.
We rename useTransRole to useTrans to make it more general and reusable. It will be used for all reusable doc translation.
We can now create a doc in one click. The doc will be created with a default name, the user will be able to edit the name inline.
AntoLC
force-pushed
the
feature/editable-title
branch
from
a894269
to
e678bea
Compare
We can now edit the title of the document inline. This is a feature that is very useful for users who want to change the title of the document without having to go to the document management page.
We can now update the title directly in the header, so we don't need the update title modal anymore. We remove the buttons to trigger the modal and the modal itself.
We need to get the headings in multiple places. To not have multiple listeners to compute the same thing, we will use a store to store the editor headings.
When we create a new document, the initial content is now a heading instead of a paragraph. This is to make it easier to set the title of the document.
When the title of the doc is not set, the first heading is used as the title of the document.
To keep the codebase clean and organized, we moved the Markdown button to its own file.
AntoLC
force-pushed
the
feature/editable-title
branch
from
e678bea
to
911fa7b
Compare
AntoLC
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We want to reduce friction for document creation.
We want the user to be able to create document with a single click wihout having to type in the title and then allow for editing the title in place.
If no title is set, the first editor heading is used as the title of the document.
Proposal
Demo
scrnli_10_2_2024_11-54-29.AM.webm