Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Parquet and remove diagTree, ExprTree, and old parquet_builder #172

Merged
merged 9 commits into from
Jan 10, 2024

Conversation

houpc
Copy link
Member

@houpc houpc commented Jan 10, 2024

  1. Remove DiagTree and ExprTree Modules.
  2. Update the Parquet module in src/frontend/parquet/ & Remove src/parquet_builder.
  3. Remove the factor field in AbstractGraph type.
  4. Relocation of DiagPara to Parquet Module.

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

Attention: 222 lines in your changes are missing coverage. Please review.

Comparison is base (1624693) 57.95% compared to head (286cbbc) 56.11%.
Report is 6 commits behind head on computgraph.

Files Patch % Lines
src/computational_graph/transform.jl 1.63% 60 Missing ⚠️
src/frontend/parquet/diagram_id.jl 41.37% 34 Missing ⚠️
src/frontend/parquet/operation.jl 50.81% 30 Missing ⚠️
src/backend/to_dot.jl 0.00% 23 Missing ⚠️
src/frontend/parquet/common.jl 68.85% 19 Missing ⚠️
src/frontend/parquet/parquet.jl 56.25% 14 Missing ⚠️
src/frontend/parquet/ep_coupling.jl 0.00% 12 Missing ⚠️
src/backend/compiler_python.jl 0.00% 6 Missing ⚠️
src/frontend/parquet/sigmaGV.jl 0.00% 6 Missing ⚠️
src/utility.jl 58.33% 5 Missing ⚠️
... and 8 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff               @@
##           computgraph     #172      +/-   ##
===============================================
- Coverage        57.95%   56.11%   -1.84%     
===============================================
  Files               67       51      -16     
  Lines             5294     4496     -798     
===============================================
- Hits              3068     2523     -545     
+ Misses            2226     1973     -253     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@houpc houpc self-assigned this Jan 10, 2024
@houpc houpc added the refactor refactor the code label Jan 10, 2024
@houpc houpc merged commit c0b2894 into computgraph Jan 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor refactor the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants