Refactor taylor expansion #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## computgraph #155 +/- ##
===============================================
+ Coverage 63.75% 68.07% +4.31%
===============================================
Files 64 64
Lines 4442 4501 +59
===============================================
+ Hits 2832 3064 +232
+ Misses 1610 1437 -173
☔ View full report in Codecov by Sentry. |
kunyuan
reviewed
Nov 11, 2023
| function eval!(g::FeynmanGraph{F,W}, leafmap::Dict{Int,Int}=Dict{Int,Int}(), leaf::Vector{W}=Vector{W}()) where {F,W} | ||
| result = nothing | ||
|
|
||
| for node in PostOrderDFS(g) | ||
| if isleaf(node) | ||
| node.weight = leaf[leafmap[node.id]] | ||
| if isempty(leafmap) | ||
| node.weight = 1.0 |
kunyuan
approved these changes
Nov 11, 2023
kunyuan
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.Refactor taylor exapansion api. Add support to taylor expansion of FeynmanGraph and DiagTree (no need to convert them to Graph first).
2. Default variable dependence of taylor expansion is changed. If dependence is not provided for some nodes, they are assumed to depend on no variables (meaning that their expansion only has order zero term)
3. Benchmark taylor expansion with sigmaGV FeynmanGraphs.
TODO: