Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back orders #144

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Add back orders #144

merged 2 commits into from
Oct 16, 2023

Conversation

dcerkoney
Copy link
Collaborator

  1. Add back field orders to graph, move orders from FeynmanProperties to field in FeynmanGraph.
  2. Add orders(g::Graph) and orders(g::FeynmanGraph) helper functions.
  3. Remove unnecessary parametric types (use idiom v::AbstractVector{<:AbstractT} instead of v::AbstractVector{T} ... where {T<:AbstractT}).

@dcerkoney dcerkoney added the refactor refactor the code label Oct 10, 2023
@dcerkoney dcerkoney self-assigned this Oct 10, 2023
@dcerkoney dcerkoney changed the title Computgraph daniel Add back orders Oct 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (a724e61) 61.24% compared to head (9af118e) 61.15%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
- Coverage   61.24%   61.15%   -0.10%     
==========================================
  Files          56       56              
  Lines        3427     3437      +10     
==========================================
+ Hits         2099     2102       +3     
- Misses       1328     1335       +7     
Files Coverage Δ
src/computational_graph/feynmangraph.jl 91.44% <100.00%> (ø)
src/computational_graph/graph.jl 95.12% <100.00%> (+0.38%) ⬆️
src/computational_graph/optimize.jl 93.57% <100.00%> (ø)
src/quantum_operator/expression.jl 96.55% <100.00%> (ø)
src/computational_graph/abstractgraph.jl 75.75% <66.66%> (ø)
src/backend/static.jl 41.37% <50.00%> (ø)
src/computational_graph/io.jl 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dcerkoney dcerkoney merged commit 418f8f5 into master Oct 16, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor refactor the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants