Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versioneer to 3.12 #102

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Update versioneer to 3.12 #102

merged 3 commits into from
Apr 9, 2024

Conversation

esc
Copy link
Member

@esc esc commented Apr 8, 2024

using versioneer install --vendor in a 3.12 env

@esc esc added this to the 0.4.0 milestone Apr 8, 2024
Copy link
Member

@sklam sklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes are good but GHA CI is not happy!? Why are jobs cancelled?

esc added 2 commits April 8, 2024 18:15
using `versioneer install --vendor` in a 3.12 env
@esc
Copy link
Member Author

esc commented Apr 8, 2024

Code changes are good but GHA CI is not happy!? Why are jobs cancelled?

Not sure yet, seems like one failed job causes the others to fail too, have to triage some more.

@esc
Copy link
Member Author

esc commented Apr 9, 2024

@sklam seems like the CI system isn't quite ready to be bumped to 3.12 just yet, I reverted the bump and seems like all tests are passing now.

The GHA works like this: we build a package on 3.10 and then test on 3.8 -- 3.11 . When adding 3.12 to the mix we end up with:

Run conda install -c numba python=3.12 numba>=0.45 'scipy>=1.4,<1.11.0' 'numpy>=1.22.0' flake8 pytest

to setup the test env. But then attempting to install the build artifact in this environment yields:

LibMambaUnsatisfiableError: Encountered problems while solving:
  - nothing provides numpy-base 1.23.3 py310h375b286_0 needed by numpy-1.23.3-py310hac523dd_0

Which is odd as the py310 string in the package name suggests mamba is attempting to install a NumPy for Python 3.10 but on 3.12?

My suggestion here is to divide and conquer. Since this PR only affects the vendored versioneer files -- which seem to pass on the current CI config -- and these files are auto-generated -- so would suggest to get this merged up and refactor and fixup support for 3.12 in a subsequent PR?

Copy link
Member

@sklam sklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that we should divide and conqueur.

@esc esc merged commit e60cf3a into numba:main Apr 9, 2024
31 checks passed
@esc esc deleted the update_versioneer_3.12 branch April 9, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants