Opaque pointer fixes #1158
Open
Opaque pointer fixes #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What are the issues? Are there any test cases that should be added to clarify / check that the issues are resolved? |
|
Hi @gmarkall, just added a few tests for this. I wasn't sure where to place them, so I created new methods for them. Please let me know if you have a better idea! |
rj-jesus
commented
Feb 20, 2025
Comment on lines
+2478
to
+2479
| self.assertEqual(ir.PointerType(int1).intrinsic_name, 'p0i1') | ||
| self.assertEqual(ir.PointerType(int1, 1).intrinsic_name, 'p1i1') |
There was a problem hiding this comment.
I think these need to be changed in opaque pointer mode to emit p<addrspace> unconditionally. Should we wait for #1160 to fix this by removing the .intrinsic_name from typed pointers? Or would you rather I add a path for opaque_pointer_enabled similar to what we have for _to_string?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few issues @stuartarchibald and I found with opaque pointers.