Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Asynchronous Map Implementation for Pipeline #2295

Merged
merged 17 commits into from
Dec 24, 2024
Merged

feat: Asynchronous Map Implementation for Pipeline #2295

merged 17 commits into from
Dec 24, 2024

Conversation

yhl25
Copy link
Contributor

@yhl25 yhl25 commented Dec 18, 2024

No description provided.

Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
@yhl25 yhl25 changed the title feat: Asynchronous Streaming for Map feat: Asynchronous Map Implementation for Pipeline Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 93.90244% with 140 lines in your changes missing coverage. Please review.

Project coverage is 67.22%. Comparing base (dfae989) to head (7b19ce1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
rust/numaflow-core/src/mapper/map.rs 96.11% 35 Missing ⚠️
rust/numaflow-core/src/mapper/map/user_defined.rs 97.26% 15 Missing ⚠️
rust/numaflow-core/src/pipeline.rs 95.52% 14 Missing ⚠️
rust/numaflow-core/src/transformer.rs 88.61% 14 Missing ⚠️
rust/numaflow-core/src/tracker.rs 65.62% 11 Missing ⚠️
rust/numaflow-core/src/metrics.rs 0.00% 9 Missing ⚠️
rust/numaflow-core/src/config/pipeline.rs 94.85% 7 Missing ⚠️
rust/numaflow-core/src/shared/create_components.rs 85.41% 7 Missing ⚠️
...aflow-core/src/pipeline/forwarder/map_forwarder.rs 83.78% 6 Missing ⚠️
...numaflow-core/src/pipeline/isb/jetstream/reader.rs 79.16% 5 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2295      +/-   ##
==========================================
+ Coverage   65.85%   67.22%   +1.36%     
==========================================
  Files         346      349       +3     
  Lines       42801    44965    +2164     
==========================================
+ Hits        28186    30226    +2040     
- Misses      13542    13666     +124     
  Partials     1073     1073              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yhl25 yhl25 marked this pull request as ready for review December 22, 2024 16:24
@yhl25 yhl25 requested review from whynowy and vigith as code owners December 22, 2024 16:24
vigith and others added 5 commits December 22, 2024 08:56
Signed-off-by: Vigith Maurice <[email protected]>
Signed-off-by: Vigith Maurice <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Vigith Maurice <[email protected]>
@vigith vigith enabled auto-merge (squash) December 24, 2024 03:18
@vigith vigith merged commit 8128476 into main Dec 24, 2024
28 checks passed
@vigith vigith deleted the async-map branch December 24, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants