-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: E2E tests for built-in Pulsar source #2260
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Sreekanth <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2260 +/- ##
==========================================
+ Coverage 67.09% 67.12% +0.02%
==========================================
Files 351 351
Lines 45269 45269
==========================================
+ Hits 30375 30388 +13
+ Misses 13825 13812 -13
Partials 1069 1069 ☔ View full report in Codecov by Sentry. |
Please consider adding it to the builtin-source-e2e suite instead of creating a new one. Otherwise, you need to add it to the .github/workflows/ci.yaml |
Signed-off-by: Sreekanth <[email protected]>
I've added it to |
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
This reverts commit 59103e5. Signed-off-by: Sreekanth <[email protected]>
Snyk reports vulnerabilities with 2 indirect dependencies that got added when I added
I tried upgrading these indirect dependencies, but then all other tests started failing https://github.com/numaproj/numaflow/actions/runs/12193339406
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BulkBeing please add the CI
The test is present in the CI pipeline ( |
@@ -123,7 +133,9 @@ require ( | |||
github.com/google/gofuzz v1.2.0 // indirect | |||
github.com/gorilla/handlers v1.5.2 // indirect | |||
github.com/gorilla/websocket v1.5.0 // indirect | |||
github.com/hashicorp/errwrap v1.0.0 // indirect | |||
github.com/gsterjov/go-libsecret v0.0.0-20161001094733-a6f4afe4910c // indirect | |||
github.com/hamba/avro/v2 v2.22.2-0.20240625062549-66aad10411d9 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can not be introduced, CVE-2023-37475, already been tagged by Intuit security.
Explain what this PR does.
Closes #2254