Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: write server info for sideinput sdk #130

Merged
merged 3 commits into from
Jan 30, 2024
Merged

chore: write server info for sideinput sdk #130

merged 3 commits into from
Jan 30, 2024

Conversation

ayildirim21
Copy link
Member

Implements: Issue 1457 for the Python sdk

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (39ec103) 95.15% compared to head (015c32c) 95.15%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #130   +/-   ##
=======================================
  Coverage   95.15%   95.15%           
=======================================
  Files          45       45           
  Lines        1424     1424           
  Branches       81       81           
=======================================
  Hits         1355     1355           
  Misses         50       50           
  Partials       19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kohlisid
Copy link
Contributor

We are about to merge #129
Could wait for merging this in till that, might want to rebase on top of it as it has many changes

@ayildirim21 ayildirim21 requested a review from vigith January 29, 2024 18:10
@KeranYang KeranYang requested a review from kohlisid January 29, 2024 18:24
@kohlisid
Copy link
Contributor

kohlisid commented Jan 30, 2024

@a3hadi Please run lint on your codebase once and re-upload
It can be done by the command from project base directory
make lint

@KeranYang KeranYang merged commit f0b43aa into numaproj:main Jan 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants