chore: update multiproc to use explicit ports for connection #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
=======================================
Coverage 95.21% 95.21%
=======================================
Files 33 33
Lines 1359 1359
Branches 89 89
=======================================
Hits 1294 1294
Misses 36 36
Partials 29 29 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
whynowy
reviewed
Dec 21, 2023
ab93
reviewed
Dec 21, 2023
| @@ -87,8 +85,9 @@ def __init__( | |||
| ("grpc.so_reuseport", 1), | |||
| ("grpc.so_reuseaddr", 1), | |||
| ] | |||
| self._sock_path = sock_path | |||
| self._process_count = int(os.getenv("NUM_CPU_MULTIPROC") or os.cpu_count()) | |||
There was a problem hiding this comment.
Suggested change
| self._process_count = int(os.getenv("NUM_CPU_MULTIPROC") or os.cpu_count()) | |
| self._process_count = int(os.getenv("NUM_CPU_MULTIPROC")) or (2 * os.cpu_count()) |
default can be twice the cpu count right?
There was a problem hiding this comment.
The default should be os.cpu_count() and the upper limit for the user defined can be 2*cpu_count
Signed-off-by: Sidhant Kohli <[email protected]>
Missed uploading those! Have added in this commit |
ab93
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kindly explain what this PR does.
Fixes #111