Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change to weaker type definitions #74

Closed

Conversation

YangJonghun
Copy link

Summary

change to weaker type definitions (partial revert commit bd74375)
because current definition doesn't support below case

  • dev
{
  "public": {
    "OPTIONAL1": "test",
    "REQUIRE": "false"
  }
}
  • prod
{
  "public": {
    "OPTIONAL2": "test",
    "REQUIRE": "false"
  }
}

above case we met type error

Changelog

change to weaker type definitions

Test Plan

Copy link

This PR is stale because it has been open 365 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 22, 2025
Copy link

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant