Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: iphone 16 and pro max compression issue #321

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

numandev1
Copy link
Owner

Summary

fixed #313

Changelog

[CATEGORY] [TYPE] - Message

Test Plan

@numandev1 numandev1 merged commit 9614919 into main Dec 4, 2024
2 of 3 checks passed
@numandev1 numandev1 deleted the fix/iphone-16-compression branch December 4, 2024 09:00
@gaearon
Copy link

gaearon commented Dec 5, 2024

Tried upgrading but getting this error:

❌  (/Users/[...]/social-app/node_modules/react-native-compressor/ios/Video/NextLevelSessionExporter.swift:376:69)

  374 |         for audioTrack in audioTracks {
  375 |             let mediaSubtypes = audioTrack.formatDescriptions.filter { CMFormatDescriptionGetMediaType($0 as! CMFormatDescription) == kCMMediaType_Audio }.map { CMFormatDescriptionGetMediaSubType($0 as! CMFormatDescription) }
> 376 |             for mediaSubtype in mediaSubtypes where mediaSubtype != kAudioFormatAPAC {
      |                                                                     ^ cannot find 'kAudioFormatAPAC' in scope
  377 |                 audioTracksToUse.append(audioTrack)
  378 |             }
  379 |         }

Am I doing something wrong? Is this expected?

@phuocnguyenncc
Copy link

i have same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iPhone 16 Pro and Pro Max compression issues
3 participants