Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Simplify rollup config and remove modulesOnly check that triggers unresolved dependencies error #870

Closed
wants to merge 1 commit into from

Conversation

marboro92
Copy link
Contributor

Fixes two issues

  1. Externals were incorrectly set and should be only peerDependencies
  2. We couldn't remove all the extra globals before due to unresolved modules errors, which seem to crop up when using the modulesOnly resolve setting: Using modulesOnly: true triggers unresolved dependency even when target defines module entry rollup/rollup-plugin-node-resolve#200

Description

Describe the change you're making, the motiviations behind it, and any thing else a reviewer may need to know to approve this PR.

Changes include

  • breaking change: a change that is not backwards-compatible and/or changes current functionality
  • fix: a non-breaking change that solves an issue
  • feature: a non-breaking change that adds functionality
  • chore: contains no changes affecting the library, such as documentation or test updates

Feature checklist

  • Appropriate tests have been added
  • Documentation has been updated
  • Accessibility has been considered

@marboro92 marboro92 added the beta this change is for the next beta release label Mar 12, 2021
@marboro92 marboro92 closed this Apr 12, 2021
@marboro92 marboro92 deleted the fix-peer-dependency-config branch May 27, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta this change is for the next beta release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant