Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alert: add alert-dismissible class #164

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mattscilipoti
Copy link

@mattscilipoti mattscilipoti commented Nov 22, 2016

Per https://getbootstrap.com/components/#alerts-dismissible, dismissible alert boxes should have an alert-dismissable css class.

@coveralls
Copy link

coveralls commented Nov 22, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 150b8c7 on mattscilipoti:alert_dismissible into 88a6398 on Fullscreen:master.

@claudiofullscreen
Copy link
Contributor

@mattscilipoti Is this what you are looking for?

http://fullscreen.github.io/bh/#dismissible-alerts

@mattscilipoti
Copy link
Author

mattscilipoti commented Nov 22, 2016

@claudiofullscreen Yes. That element is just missing the 'alert-dismissible' class, that bootstrap specifies should be there. My pull request simply adds that class. Bootstrap has some styling for that class.

@mattscilipoti
Copy link
Author

The broken travis build is having an issue installing json. I don't think this small change is related to that issue.

@mattscilipoti
Copy link
Author

Here is the listed failure from travis-ci. It is not related to the changes in this PR. I expect it is affecting other PRs too. I don't know how you are managing multiple rubies, but it looks like something isn't configured correctly.:

...
Gem::InstallError: json requires Ruby version ~> 2.0.
Installing tilt 1.4.1
An error occurred while installing json (2.0.2), and Bundler cannot continue.
Make sure that `gem install json -v '2.0.2'` succeeds before bundling.
The command "eval bundle install --jobs=3 --retry=3" failed. Retrying, 2 of 3.
...

Please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants