Update manifest to include logo and provider properties #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathewjordan
requested changes
Sep 21, 2023
mbklein
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
@mathewjordan's comments look apt; I'm approving on the assumption that Mat's requested changes will go in.
adamjarling
force-pushed
the
3905-nul-logo
branch
from
fd2a2c1
to
465fa2b
Compare
|
@mathewjordan Suggestions committed. Thanks! |
|
Assuming the tests just need to match the new shape. Go for it. |
Co-authored-by: mat <[email protected]>
adamjarling
force-pushed
the
3905-nul-logo
branch
from
465fa2b
to
3fea15a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Hard codes the IIIF properties
logoandproviderinto manifests we deliver. theiiif-builderhelper package we use doesn't support these properties yet, so just to move this one along, hard coding.