Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gitbook docs #365

Merged
merged 6 commits into from
Oct 31, 2023
Merged

Update Gitbook docs #365

merged 6 commits into from
Oct 31, 2023

Conversation

piotr-roslaniec
Copy link
Contributor

@piotr-roslaniec piotr-roslaniec commented Oct 24, 2023

Type of PR:

  • Documentation

Required reviews:

  • 1

What this does:

Notes for reviewers:

  • taco/src/examples are not run at the moment, but are type-checked (compiled) instead - It should catch any issues with the API, but will not catch bugs in taco. For that, we implement tests in taco/test
  • A preview of generated docs is available here: https://nucypher.github.io/nucypher-ts/

@netlify
Copy link

netlify bot commented Oct 24, 2023

Deploy Preview for taco-demo canceled.

Name Link
🔨 Latest commit 9097c71
🔍 Latest deploy log https://app.netlify.com/sites/taco-demo/deploys/6538f1e76754830008726ead

@netlify
Copy link

netlify bot commented Oct 24, 2023

Deploy Preview for taco-nft-demo canceled.

Name Link
🔨 Latest commit 9097c71
🔍 Latest deploy log https://app.netlify.com/sites/taco-nft-demo/deploys/6538f1e7ef3582000894531e

@codecov-commenter
Copy link

Codecov Report

Merging #365 (2e4dcf0) into main (4922a89) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
- Coverage   87.42%   87.41%   -0.01%     
==========================================
  Files          48       48              
  Lines        5774     5771       -3     
  Branches      225      226       +1     
==========================================
- Hits         5048     5045       -3     
  Misses        692      692              
  Partials       34       34              
Files Coverage Δ
packages/taco/src/conditions/predefined/erc721.ts 100.00% <100.00%> (ø)
packages/taco/test/test-utils.ts 97.21% <100.00%> (+0.01%) ⬆️

@piotr-roslaniec piotr-roslaniec force-pushed the update-docs branch 3 times, most recently from c451469 to 822da94 Compare October 25, 2023 10:31
@piotr-roslaniec piotr-roslaniec marked this pull request as ready for review October 25, 2023 14:54
@KPrasch KPrasch merged commit 9097c71 into nucypher:main Oct 31, 2023
@piotr-roslaniec piotr-roslaniec deleted the update-docs branch November 3, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

Update Gitbook docs post monorepo merge
3 participants