Release chores #336
Merged
Release chores #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #336 +/- ##
=======================================
Coverage 87.32% 87.32%
=======================================
Files 33 33
Lines 2462 2462
Branches 206 206
=======================================
Hits 2150 2150
Misses 282 282
Partials 30 30 |
Closed
10 tasks
piotr-roslaniec
requested review from
jMyles,
KPrasch,
cygnusv,
theref,
derekpierre and
manumonti
KPrasch
reviewed
Oct 19, 2023
README.md
Outdated
| @@ -8,7 +8,7 @@ Full documentation can be found [here](https://docs.threshold.network/app-develo | |||
| > | |||
| > `nucypher-ts` is under [active development](https://github.com/nucypher/nucypher-ts/pulls): | |||
| > | |||
| > - SDK does not support policy revocation. | |||
| > - SDK does not support access revocation. | |||
There was a problem hiding this comment.
I think we can safely remove this now? It's not a true statement anymore since access can be revoked by way of policy expiration or unsatisfied on-chain condition.
KPrasch
reviewed
Oct 19, 2023
Comment on lines
+32
to
33
| These examples showcase integration with web applications and an end-to-end flow of creating conditioned encryption, and encrypting & decrypting data. | ||
|
|
KPrasch
approved these changes
Oct 19, 2023
derekpierre
reviewed
Oct 19, 2023
| @@ -13,17 +15,18 @@ | |||
| }, | |||
| "files": [], | |||
| "references": [ | |||
| // Order matters | |||
There was a problem hiding this comment.
@piotr-roslaniec Was this auto-generated? - JSON doesn't allow for comments.
There was a problem hiding this comment.
It's not autogenerated. Yes, JSON doesn't allow comments, but tsconfig.json is not a strict JSON and it allows comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
Issues fixed/closed:
@nucypher/taco#308Why it's needed:
Notes for reviewers: