Refactor packages APIs

packages/taco/src/conditions/base/rpc.ts

@@ -11,9 +11,11 @@ export const rpcConditionSchema = z.object({
   conditionType: z.literal(RpcConditionType).default(RpcConditionType),
   chain: createUnionSchema(SUPPORTED_CHAIN_IDS),
   method: z.enum(['eth_getBalance', 'balanceOf']),
-  parameters: z.array(
-    z.union([EthAddressOrUserAddressSchema, z.string(), z.number()]),
-  ),
+  parameters: z.union([
+    z.array(EthAddressOrUserAddressSchema).length(1),
+    // Using tuple here because ordering matters
+    z.tuple([EthAddressOrUserAddressSchema, z.union([z.string(), z.number()])]),
+  ]),
   returnValueTest: returnValueTestSchema,
 });
 

packages/taco/test/conditions/base/rpc.test.ts

@@ -1,3 +1,4 @@
+import { TEST_CONTRACT_ADDR } from '@nucypher/test-utils';
 import { describe, expect, it } from 'vitest';
 
 import { RpcCondition } from '../../../src/conditions';
@@ -34,4 +35,52 @@ describe('validation', () => {
       },
     });
   });
+
+  describe('parameters', () => {
+    it('accepts a single address', () => {
+      const result = RpcCondition.validate(rpcConditionSchema, {
+        ...testRpcConditionObj,
+        parameters: [TEST_CONTRACT_ADDR],
+      });
+
+      expect(result.error).toBeUndefined();
+      expect(result.data).toEqual({
+        ...testRpcConditionObj,
+        parameters: [TEST_CONTRACT_ADDR],
+      });
+    });
+
+    it('accepts a single address and a block number', () => {
+      const result = RpcCondition.validate(rpcConditionSchema, {
+        ...testRpcConditionObj,
+        parameters: [TEST_CONTRACT_ADDR, 'latest'],
+      });
+
+      expect(result.error).toBeUndefined();
+      expect(result.data).toEqual({
+        ...testRpcConditionObj,
+        parameters: [TEST_CONTRACT_ADDR, 'latest'],
+      });
+    });
+
+    it('rejects on an extra parameter', () => {
+      const result = RpcCondition.validate(rpcConditionSchema, {
+        ...testRpcConditionObj,
+        parameters: [
+          TEST_CONTRACT_ADDR,
+          'latest',
+          // Intentionally adding a third, invalid parameter
+          '0x1234',
+        ],
+      });
+
+      expect(result.error).toBeDefined();
+      expect(result.data).toBeUndefined();
+      expect(result.error?.format()).toMatchObject({
+        parameters: {
+          _errors: ['Array must contain exactly 1 element(s)'],
+        },
+      });
+    });
+  });
 });