Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sc-11314] Add option to collapse text blocks #1909

Merged

Conversation

operramon
Copy link
Contributor

No description provided.

@operramon operramon requested a review from a team as a code owner January 10, 2025 15:09
Copy link
Collaborator

@ebrehault ebrehault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, if the collapseTextBlocks option is on, the user will alredy have to click once to see the details of a given result, so we do not want them to need to click anything else.
So the we should not collapse paragraphs and we should directly display all results:

image

@operramon operramon merged commit 9716e13 into main Jan 13, 2025
2 checks passed
@operramon operramon deleted the oriolperramon8396/sc-11314/option-to-collapse-paragraphs branch January 13, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants