put github signin on feature flag (#1177)

* put github signin on feature flag * fix test
nuclia · Dec 8, 2023 · 1307088 · 1307088
1 parent 59002a2
commit 1307088
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 6 deletions.
diff --git a/libs/user/src/lib/signup/signup.component.html b/libs/user/src/lib/signup/signup.component.html
@@ -50,9 +50,11 @@ <h1>{{ 'signup.title' | translate }}</h1>
       <stf-sso-button
         provider="google"
         signup></stf-sso-button>
-      <stf-sso-button
-        provider="github"
-        signup></stf-sso-button>
+      @if (isGitHubEnabled | async) {
+        <stf-sso-button
+          provider="github"
+          signup></stf-sso-button>
+      }
     </div>
 
     <p class="existing-account">

diff --git a/libs/user/src/lib/signup/signup.component.spec.ts b/libs/user/src/lib/signup/signup.component.spec.ts
@@ -7,8 +7,8 @@ import { ReactiveFormsModule } from '@angular/forms';
 import { UserContainerComponent } from '../user-container';
 import { RouterTestingModule } from '@angular/router/testing';
 import { ReCaptchaV3Service } from 'ngx-captcha';
-import { BackendConfigurationService, LoginService, SignupResponse } from '@flaps/core';
-import { BehaviorSubject } from 'rxjs';
+import { BackendConfigurationService, FeatureFlagService, LoginService, SignupResponse } from '@flaps/core';
+import { BehaviorSubject, of } from 'rxjs';
 import { Router } from '@angular/router';
 import { SisPasswordInputModule } from '@nuclia/sistema';
 import { Component } from '@angular/core';
@@ -46,6 +46,9 @@ describe('SignupComponent', () => {
         MockProvider(LoginService, {
           signup: jest.fn(() => signupResponse.asObservable()),
         }),
+        MockProvider(FeatureFlagService, {
+          isFeatureEnabled: jest.fn(() => of(true)),
+        }),
         MockProvider(BackendConfigurationService, {
           getRecaptchaKey: () => 'fake',
         }),

diff --git a/libs/user/src/lib/signup/signup.component.ts b/libs/user/src/lib/signup/signup.component.ts
@@ -1,7 +1,7 @@
 import { ChangeDetectionStrategy, ChangeDetectorRef, Component, OnInit } from '@angular/core';
 import { FormControl, FormGroup, Validators } from '@angular/forms';
 import { ReCaptchaV3Service } from 'ngx-captcha';
-import { BackendConfigurationService, LoginService } from '@flaps/core';
+import { BackendConfigurationService, FeatureFlagService, LoginService } from '@flaps/core';
 import { Subject } from 'rxjs';
 import { ActivatedRoute, Router } from '@angular/router';
 import { IErrorMessages } from '@guillotinaweb/pastanaga-angular';
@@ -41,6 +41,7 @@ export class SignupComponent implements OnInit {
   get emailControl() {
     return this.signupForm.controls['email'];
   }
+  isGitHubEnabled = this.featureFlag.isFeatureEnabled('github-signin');
 
   constructor(
     private router: Router,
@@ -49,6 +50,7 @@ export class SignupComponent implements OnInit {
     private loginService: LoginService,
     public config: BackendConfigurationService,
     private cdr: ChangeDetectorRef,
+    private featureFlag: FeatureFlagService,
   ) {}
 
   ngOnInit(): void {