Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors GenerateBenthosConfigs activity for easier testing #493

Merged
merged 18 commits into from
Nov 3, 2023

Conversation

nickzelei
Copy link
Member

@nickzelei nickzelei commented Nov 3, 2023

Also adds in sqlc for sql stmt generation.

Copy link

vercel bot commented Nov 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
neosync-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2023 9:24pm

@nickzelei nickzelei marked this pull request as draft November 3, 2023 18:40
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #493 (0734c8c) into main (794280e) will increase coverage by 9.26%.
Report is 1 commits behind head on main.
The diff coverage is 31.59%.

@@            Coverage Diff             @@
##             main     #493      +/-   ##
==========================================
+ Coverage   51.10%   60.36%   +9.26%     
==========================================
  Files          45       46       +1     
  Lines        3620     3477     -143     
==========================================
+ Hits         1850     2099     +249     
+ Misses       1561     1145     -416     
- Partials      209      233      +24     
Files Coverage Δ
worker/internal/dbschemas/mysql/mysql.go 67.24% <0.00%> (+37.31%) ⬆️
worker/internal/dbschemas/postgres/postgres.go 64.94% <25.00%> (+30.55%) ⬆️
...er/pkg/workflows/datasync/activities/activities.go 55.98% <38.23%> (+39.73%) ⬆️
...g/workflows/datasync/activities/benthos-builder.go 31.69% <31.69%> (ø)

... and 2 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@nickzelei nickzelei marked this pull request as ready for review November 3, 2023 21:23
@nickzelei nickzelei changed the title Testing workflow activity Refactors GenerateBenthosConfigs activity for easier testing Nov 3, 2023
@nickzelei nickzelei merged commit 20bc532 into main Nov 3, 2023
11 of 12 checks passed
@nickzelei nickzelei deleted the nick/activity-tests branch November 3, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant