Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEOS-251: refactor email transformer and take our faker lib #475

Merged
merged 2 commits into from
Nov 1, 2023

refactor email transformer and take our faker lib

77a5379
Select commit
Loading
Failed to load commit list.
Merged

NEOS-251: refactor email transformer and take our faker lib #475

refactor email transformer and take our faker lib
77a5379
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project failed Nov 1, 2023 in 0s

42.65% (-1.41%) compared to 8b9b228

View this Pull Request on Codecov

42.65% (-1.41%) compared to 8b9b228

Details

Codecov Report

Merging #475 (77a5379) into main (8b9b228) will decrease coverage by 1.41%.
Report is 1 commits behind head on main.
The diff coverage is 55.35%.

❗ Current head 77a5379 differs from pull request most recent head 9beb9d0. Consider uploading reports for the commit 9beb9d0 to get more accurate results

@@            Coverage Diff             @@
##             main     #475      +/-   ##
==========================================
- Coverage   44.06%   42.65%   -1.41%     
==========================================
  Files          41       25      -16     
  Lines        2907     2363     -544     
==========================================
- Hits         1281     1008     -273     
+ Misses       1511     1238     -273     
- Partials      115      117       +2     
Files Coverage Δ
worker/internal/benthos/transformers/email.go 56.00% <55.35%> (-21.50%) ⬇️

... and 18 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more