Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEOS-1695: support creating schemas if they dont exist not just table #3103

Conversation

nickzelei
Copy link
Member

@nickzelei nickzelei commented Jan 7, 2025

can't believe we didn't do this sooner.

fast follow is updating manager tests to further test this alongwith restructuring them to be faster

@nickzelei nickzelei added the enhancement New feature or request label Jan 7, 2025
Copy link

linear bot commented Jan 7, 2025

Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
neosync-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 0:06am

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 25.80645% with 46 lines in your changes missing coverage. Please review.

Project coverage is 31.01%. Comparing base (79b11fd) to head (caef743).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...run-sql-init-table-stmts/init-statement-builder.go 16.66% 25 Missing ⚠️
...ackend/pkg/sqlmanager/postgres/postgres-manager.go 0.00% 12 Missing ⚠️
internal/ee/mssql-manager/ee-mssql-manager.go 0.00% 8 Missing ⚠️
backend/services/mgmt/v1alpha1/job-service/runs.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3103      +/-   ##
==========================================
- Coverage   31.01%   31.01%   -0.01%     
==========================================
  Files         368      368              
  Lines       41999    42052      +53     
==========================================
+ Hits        13028    13043      +15     
- Misses      27437    27474      +37     
- Partials     1534     1535       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nickzelei nickzelei merged commit 6bd2bb8 into main Jan 8, 2025
16 of 18 checks passed
@nickzelei nickzelei deleted the nick/neos-1695-support-creating-schemas-if-they-dont-exist-not-just-table branch January 8, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants