NEOS-1672: Fixes Neosync worker shutdown, adds revisioning to helm chart secrets #3043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nickzelei
commented
Dec 12, 2024
nickzelei
commented
- Fixes the worker not properly shutting down. This was a result if not actually calling defer Shutdown on both connection managers which was causing it to hang indefinitely
- Adds a sha tag to service secrets in helm which causes new secrets to be generated any time a revision is made. This fixes the issue of environment variables never being removed from the secret file.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
nickzelei
force-pushed
the
nick/neos-1672-invalid-redis-configurations-causing-worker-to-silently-fail
branch
from
a74d997 to
25aeff6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.