-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEOS-1616: [MIGRATION] Adds RBAC engine #2935
Merged
nickzelei
merged 26 commits into
main
from
nick/neos-1616-add-support-for-rbac-to-neosync
Dec 16, 2024
Merged
NEOS-1616: [MIGRATION] Adds RBAC engine #2935
nickzelei
merged 26 commits into
main
from
nick/neos-1616-add-support-for-rbac-to-neosync
Dec 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
nickzelei
force-pushed
the
nick/neos-1616-add-support-for-rbac-to-neosync
branch
from
December 10, 2024 21:13
349d918
to
648ecfa
Compare
nickzelei
force-pushed
the
nick/neos-1616-add-support-for-rbac-to-neosync
branch
from
December 13, 2024 17:58
0e36ce4
to
2ed2760
Compare
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
nickzelei
changed the title
Adds initial rbac casbin logic and policy init
NEOS-1616: [MIGRATION] Adds RBAC engine
Dec 13, 2024
alishakawaguchi
approved these changes
Dec 13, 2024
nickzelei
commented
Dec 14, 2024
@@ -11,4 +11,4 @@ g = _, _, _ | |||
e = some(where (p.eft == allow)) | |||
|
|||
[matchers] | |||
m = g(r.sub, p.sub, r.dom) && r.dom == p.dom && keyMatch2(r.obj, p.obj) && keyMatch2(r.act, p.act) | |||
m = g(r.sub, p.sub, r.dom) && r.dom == p.dom && keyMatch(r.obj, p.obj) && keyMatch(r.act, p.act) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after more inspection of the functions available, keyMatch is what we actually want.
https://casbin.org/docs/function/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is kind of a large PR but it does a few things here:
userdata
service that now encapsulates all of the previous checks we were doing in theuser-account.go
files, as well as ensures the user is in the requesting resource's accountEach account now has the following roles: