refactor out null transformer

nucleuscloud · Nov 3, 2023 · 6a63186 · 6a63186
1 parent 3e1bb91
commit 6a63186
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 43 deletions.
diff --git a/worker/internal/benthos/transformers/null.go b/worker/internal/benthos/transformers/null.go
diff --git a/worker/internal/benthos/transformers/null_test.go b/worker/internal/benthos/transformers/null_test.go
diff --git a/worker/pkg/workflows/datasync/activities/activities.go b/worker/pkg/workflows/datasync/activities/activities.go
@@ -1064,7 +1064,7 @@ func computeMutationFunction(col *mgmtv1alpha1.JobMapping) (string, error) {
 		ih := col.Transformer.Config.GetUuidConfig().IncludeHyphen
 		return fmt.Sprintf("uuidtransformer(%t)", ih), nil
 	case "null":
-		return "transformernull()", nil
+		return "null", nil
 	case "random_bool":
 		return "randombooltransformer()", nil
 	case "random_string":

diff --git a/worker/pkg/workflows/datasync/activities/activities_test.go b/worker/pkg/workflows/datasync/activities/activities_test.go
@@ -296,3 +296,13 @@ func strPtr(val string) *string {
 func boolPtr(val bool) *bool {
 	return &val
 }
+
+func TestNullTransformer(t *testing.T) {
+
+	val, err := computeMutationFunction(&mgmtv1alpha1.JobMapping{Transformer: &mgmtv1alpha1.Transformer{
+		Value: "null"}})
+
+	assert.NoError(t, err)
+
+	assert.Equal(t, val, "null")
+}