Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency sphinx to v8 #611

Open
wants to merge 1 commit into
base: 3.10.x
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Pygments==2.19.1
sphinx==6.2.1
sphinx==8.1.3
sphinx_rtd_theme==2.0.0

Unchanged files with check annotations Beta

public function getUserIdentifier(): string
{
return $this->getUsername();

Check failure on line 58 in tests/App/Entity/User.php

GitHub Actions / run / Static Code Analysis (8.3)

Method Nucleos\UserAdminBundle\Tests\App\Entity\User::getUserIdentifier() should return non-empty-string but returns string.
}
public function toString(): string
{
$username = $request->query->get('username', '');
if ('' === trim($username)) {

Check warning on line 54 in src/Action/CheckEmailAction.php

GitHub Actions / run / Mutation Tests (8.3)

Escaped Mutant for Mutator "UnwrapTrim": @@ @@ public function __invoke(Request $request): Response { $username = $request->query->get('username', ''); - if ('' === trim($username)) { + if ('' === $username) { // the user does not come from the sendEmail action return new RedirectResponse($this->urlGenerator->generate('nucleos_user_admin_resetting_request')); }
// the user does not come from the sendEmail action
return new RedirectResponse($this->urlGenerator->generate('nucleos_user_admin_resetting_request'));
}
$this->twig->render('@NucleosUserAdmin/Admin/Security/Resetting/checkEmail.html.twig', [
'base_template' => $this->templateRegistry->getTemplate('layout'),
'admin_pool' => $this->adminPool,
'tokenLifetime' => ceil($this->resetTtl / 3600),

Check warning on line 63 in src/Action/CheckEmailAction.php

GitHub Actions / run / Mutation Tests (8.3)

Escaped Mutant for Mutator "DecrementInteger": @@ @@ // the user does not come from the sendEmail action return new RedirectResponse($this->urlGenerator->generate('nucleos_user_admin_resetting_request')); } - return new Response($this->twig->render('@NucleosUserAdmin/Admin/Security/Resetting/checkEmail.html.twig', ['base_template' => $this->templateRegistry->getTemplate('layout'), 'admin_pool' => $this->adminPool, 'tokenLifetime' => ceil($this->resetTtl / 3600)])); + return new Response($this->twig->render('@NucleosUserAdmin/Admin/Security/Resetting/checkEmail.html.twig', ['base_template' => $this->templateRegistry->getTemplate('layout'), 'admin_pool' => $this->adminPool, 'tokenLifetime' => ceil($this->resetTtl / 3599)])); } }

Check warning on line 63 in src/Action/CheckEmailAction.php

GitHub Actions / run / Mutation Tests (8.3)

Escaped Mutant for Mutator "IncrementInteger": @@ @@ // the user does not come from the sendEmail action return new RedirectResponse($this->urlGenerator->generate('nucleos_user_admin_resetting_request')); } - return new Response($this->twig->render('@NucleosUserAdmin/Admin/Security/Resetting/checkEmail.html.twig', ['base_template' => $this->templateRegistry->getTemplate('layout'), 'admin_pool' => $this->adminPool, 'tokenLifetime' => ceil($this->resetTtl / 3600)])); + return new Response($this->twig->render('@NucleosUserAdmin/Admin/Security/Resetting/checkEmail.html.twig', ['base_template' => $this->templateRegistry->getTemplate('layout'), 'admin_pool' => $this->adminPool, 'tokenLifetime' => ceil($this->resetTtl / 3601)])); } }
])
);
}
}
$event = new GetResponseLoginEvent($request);
$this->eventDispatcher->dispatch($event, NucleosUserEvents::SECURITY_LOGIN_INITIALIZE);

Check warning on line 109 in src/Action/LoginAction.php

GitHub Actions / run / Mutation Tests (8.3)

Escaped Mutant for Mutator "MethodCallRemoval": @@ @@ return new RedirectResponse($this->router->generate('sonata_admin_dashboard')); } $event = new GetResponseLoginEvent($request); - $this->eventDispatcher->dispatch($event, NucleosUserEvents::SECURITY_LOGIN_INITIALIZE); + if (null !== $event->getResponse()) { return $event->getResponse(); }
if (null !== $event->getResponse()) {
return $event->getResponse();
'action' => $this->router->generate('nucleos_user_admin_security_check'),
'method' => 'POST',
])
->add('save', SubmitType::class, [

Check warning on line 127 in src/Action/LoginAction.php

GitHub Actions / run / Mutation Tests (8.3)

Escaped Mutant for Mutator "ArrayItemRemoval": @@ @@ $url = '' !== $refererUri && $refererUri !== $request->getUri() ? $refererUri : $this->router->generate('sonata_admin_dashboard'); return new RedirectResponse($url); } - $form = $this->formFactory->create(LoginFormType::class, null, ['action' => $this->router->generate('nucleos_user_admin_security_check'), 'method' => 'POST'])->add('save', SubmitType::class, ['label' => 'security.login.submit']); + $form = $this->formFactory->create(LoginFormType::class, null, ['action' => $this->router->generate('nucleos_user_admin_security_check'), 'method' => 'POST'])->add('save', SubmitType::class, []); // last username entered by the user return new Response($this->twig->render('@NucleosUserAdmin/Admin/Security/login.html.twig', ['form' => $form->createView(), 'admin_pool' => $this->adminPool, 'base_template' => $this->templateRegistry->getTemplate('layout'), 'csrf_token' => $this->getCsrfToken(), 'error' => $this->getLastAuthenticationError($request), 'last_username' => $this->getLastUsername($session), 'reset_route' => $this->router->generate('nucleos_user_admin_resetting_request')])); }
'label' => 'security.login.submit',
])
;
// get the error if any (works with forward and redirect -- see below)
if ($request->attributes->has($authErrorKey)) {
$error = $request->attributes->get($authErrorKey);
} elseif (null !== $session && $session->has($authErrorKey)) {

Check warning on line 165 in src/Action/LoginAction.php

GitHub Actions / run / Mutation Tests (8.3)

Escaped Mutant for Mutator "LogicalAnd": @@ @@ // get the error if any (works with forward and redirect -- see below) if ($request->attributes->has($authErrorKey)) { $error = $request->attributes->get($authErrorKey); - } elseif (null !== $session && $session->has($authErrorKey)) { + } elseif (null !== $session || $session->has($authErrorKey)) { $error = $session->get($authErrorKey); $session->remove($authErrorKey); } else {
$error = $session->get($authErrorKey);
$session->remove($authErrorKey);

Check warning on line 167 in src/Action/LoginAction.php

GitHub Actions / run / Mutation Tests (8.3)

Escaped Mutant for Mutator "MethodCallRemoval": @@ @@ $error = $request->attributes->get($authErrorKey); } elseif (null !== $session && $session->has($authErrorKey)) { $error = $session->get($authErrorKey); - $session->remove($authErrorKey); + } else { $error = null; }
} else {
$error = null;
}
if (!$error instanceof AuthenticationException) {

Check warning on line 172 in src/Action/LoginAction.php

GitHub Actions / run / Mutation Tests (8.3)

Escaped Mutant for Mutator "InstanceOf_": @@ @@ } else { $error = null; } - if (!$error instanceof AuthenticationException) { + if (!true) { $error = null; // The value does not come from the security component. }
$error = null; // The value does not come from the security component.
}
$user = $token->getUser();
return $user instanceof UserInterface;

Check warning on line 198 in src/Action/LoginAction.php

GitHub Actions / run / Mutation Tests (8.3)

Escaped Mutant for Mutator "InstanceOf_": @@ @@ return false; } $user = $token->getUser(); - return $user instanceof UserInterface; + return true; } private function getCsrfToken(): ?string {
}
private function getCsrfToken(): ?string
private function addFlash(?SessionInterface $session, string $type, string $message): void
{
if (!$session instanceof Session) {

Check warning on line 208 in src/Action/LoginAction.php

GitHub Actions / run / Mutation Tests (8.3)

Escaped Mutant for Mutator "InstanceOf_": @@ @@ } private function addFlash(?SessionInterface $session, string $type, string $message): void { - if (!$session instanceof Session) { + if (!true) { return; } $session->getFlashBag()->add($type, $message); } }
return;
}