Use yield from instead of chained iterables #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #572 +/- ##
==========================================
- Coverage 70.96% 70.95% -0.02%
==========================================
Files 288 288
Lines 25733 25733
Branches 3645 3647 +2
==========================================
- Hits 18261 18258 -3
Misses 6384 6384
- Partials 1088 1091 +3 |
|
@MatthieuDartiailh, @frmdstryr this is ready to go if y'all approve. |
MatthieuDartiailh
approved these changes
Feb 1, 2025
|
Much cleaner, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
yield fromfeature of Python 3 makes this cleaner.I didn't test locally. Let's see what the CI tests show.