Refactor declarative function and make call_func kwargs optional #569
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors declarative_function's Invoke to:
It also slightly modifies call_func:
Since all standard handlers create an empty dict and pass it to kwargs that just gets checked for a dict then ignored because it is empty. Likewise previously every dfunc call that has no kwargs was internally creating a dict just to do nothing with it in call_func. With this change the DFunc__call__'s PyObject* kwargs can be passed to call_func untouched (and if null does nothing).