Update catom to use fastcalls #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
=======================================
Coverage 97.67% 97.67%
=======================================
Files 24 24
Lines 1074 1074
Branches 162 162
=======================================
Hits 1049 1049
Misses 12 12
Partials 13 13 |
|
I think CAtom_setstate needs reworked, idk what I was doing back then... |
sccolbert
reviewed
Jan 20, 2025
atom/src/catom.cpp
Outdated
| { | ||
| if( PyTuple_GET_SIZE( args ) != 1 ) | ||
| return cppy::type_error( "__setstate__() takes exactly one argument" ); | ||
| PyObject* state = PyTuple_GET_ITEM( args, 0 ); | ||
| cppy::ptr itemsptr = PyMapping_Items(state); |
There was a problem hiding this comment.
Do we need a PyMapping_Check before this?
That said, PyMapping_Check doesn't even check for items().
Should we force it to be a dict?
Some of the below logic is questionable and may need some attention. I don't think that __setstate__ should trigger observers, which means it shouldn't go thru the __setattr__ protocol.
sccolbert
requested changes
Jan 20, 2025
frmdstryr
force-pushed
the
catom-fastcalls
branch
from
5cb71b2 to
d12ce27
Compare
|
Agree, I amended it to remove those changes. |
sccolbert
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.