Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update member.cpp to use fastcalls #231

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

frmdstryr
Copy link
Contributor

In the Member_set_x_mode functions cppy::replace does an XINCREF even though it's already checked.

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.67%. Comparing base (9b80362) to head (bde09d9).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #231   +/-   ##
=======================================
  Coverage   97.67%   97.67%           
=======================================
  Files          24       24           
  Lines        1074     1074           
  Branches      162      162           
=======================================
  Hits         1049     1049           
  Misses         12       12           
  Partials       13       13           

Copy link
Member

@sccolbert sccolbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of this is a good change and is easy to reason about. I would prefer the changes to parse_mode_and_context to be a separate change with a corresponding reason.

@frmdstryr frmdstryr force-pushed the member-to-fastcalls branch from 7d045c2 to bde09d9 Compare January 20, 2025 21:07
@MatthieuDartiailh MatthieuDartiailh merged commit c365c61 into nucleic:main Jan 20, 2025
18 checks passed
@frmdstryr
Copy link
Contributor Author

Thanks for reviewing all these PRs! Hopefully it makes everyone's code a little faster.

The only other thing I can think of possibly updating yet would be changing any of the tp_call's to use vectorcallfunc but i'm not sure how to do that yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants